8000 Repo: `yarn generate-lib` fails on main · Issue #7534 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Repo: yarn generate-lib fails on main #7534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradzacher opened this issue Aug 25, 2023 · 2 comments
Closed

Repo: yarn generate-lib fails on main #7534

bradzacher opened this issue Aug 25, 2023 · 2 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@bradzacher
Copy link
Member

Suggestion

I think there's something wrong with how yarn3 resolves binaries or something - after running a yarn install in the root I then tried running yarn generate-lib in the root and it fails with

$ yarn generate-lib        

> nx run scope-manager:generate-lib

Usage Error: Couldn't find a script named "tsx".
$ yarn run [--inspect] [--inspect-brk] [-T,--top-level] [-B,--binaries-only] <scriptName> ...
Warning: run-commands command "yarn tsx tools/generate-lib.ts" exited with non-zero status code

 ———————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  NX   Ran target generate-lib for project scope-manager (531ms)
 
    ✖    1/1 failed
    ✔    0/1 succeeded [0 read from cache]
 
   View structured, searchable error logs at https://nx.app/runs/rhV5iHc7zv

CDing into the scope manager package:

$ cd packages/scope-manager
$ yarn generate-lib
command not found: nx

So it looks like yarn won't auto read the packages from the parent dir?
@bradzacher bradzacher added bug Something isn't working repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue labels Aug 25, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 25, 2023
Merged
3 tasks
@Josh-Cena
Copy link
Member

@bradzacher: generate-lib now runs but the ESLint run at the end of the script fails:

ConfigurationNotFoundError: No ESLint configuration found in packages/scope-manager/src/lib.
    at CascadingConfigArrayFactory._finalizeConfigArray (node_modules/@eslint/eslintrc/lib/cascading-config-array-factory.js:521:19)
    at CascadingConfigArrayFactory.getConfigArrayForFile (node_modules/@eslint/eslintrc/lib/cascading-config-array-factory.js:312:21)
    at FileEnumerator._iterateFilesWithFile (node_modules/eslint/lib/cli-engine/file-enumerator.js:368:43)
    at FileEnumerator._iterateFiles (node_modules/eslint/lib/cli-engine/file-enumerator.js:349:25)
    at FileEnumerator.iterateFiles (node_modules/eslint/lib/cli-engine/file-enumerator.js:299:59)
    at iterateFiles.next (<anonymous>)
    at CLIEngine.executeOnFiles (node_modules/eslint/lib/cli-engine/cli-engine.js:797:48)
    at LegacyESLint.lintFiles (node_modules/eslint/lib/eslint/eslint.js:551:23)
    at main (packages/repo-tools/src/generate-lib.mts:305:30) {
  messageTemplate: 'no-config-found',
  messageData: {
    directoryPath: 'packages/scope-manager/src/lib'
  }
}

@JoshuaKGoldberg
Copy link
Member

Seems to work on main now.

@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Sep 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JoshuaKGoldberg @bradzacher @Josh-Cena
0