8000 Repo: Prettier tooling still runs yarn 1's --ignore-scripts · Issue #7513 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Repo: Prettier tooling still runs yarn 1's --ignore-scripts #7513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Aug 20, 2023 · 0 comments · Fixed by #7515
Closed

Repo: Prettier tooling still runs yarn 1's --ignore-scripts #7513

JoshuaKGoldberg opened this issue Aug 20, 2023 · 0 comments · Fixed by #7515
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

We've had two PRs come in recently that touch repository tooling:

  1. chore: properly checkout repo in prettier-update workflow #7483
  2. chore: upgrade to yarn 3 #6162

...and now the Prettier Update task is failing. Example from #7496 -> https://github.com/typescript-eslint/typescript-eslint/actions/runs/5919889475/job/16050593946?pr=7496:

Run yarn --ignore-scripts
Unknown Syntax Error: Unsupported option name ("--ignore-scripts").

I believe per https://yarnpkg.com/cli/install that --skip-build is Yarn 3's equivalent of --ignore-script?

FWIW neither PR did anything incorrect or wrong. Just one of those fun merge situations.

FYI @auvred @JamesHenry - I can send a PR soon if you don't have time.
@JoshuaKGoldberg JoshuaKGoldberg added bug Something isn't working repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue labels Aug 20, 2023
@auvred auvred mentioned this issue Aug 21, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use yarn v3 syntax in prettier-update workflow auvred/typescript-eslint
1 participant
@JoshuaKGoldberg
0