8000 Repo: One website test consistently failing in CI (page was closed) · Issue #7434 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Repo: One website test consistently failing in CI (page was closed) #7434< 8000 /span>

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Aug 6, 2023 · 3 comments
Closed

Repo: One website test consistently failing in CI (page was closed) #7434

JoshuaKGoldberg opened this issue Aug 6, 2023 · 3 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working repo maintenance things to do with maintenance of the repo, and not with code/docs tests anything to do with testing

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

We just can't win with these 😂. @rubiesonthesky fixed tests running from forks in #7247, and now I'm taking a closer look at remaining failures.

Example from https://github.com/typescript-eslint/typescript-eslint/actions/runs/5777607577/job/15658032893?pr=7431:

✘  1 [chromium] › index.spec.ts:15:7 › Website › Axe (30.0s)
  ✓  2 [chromium] › index.spec.ts:20:7 › Website › should have no errors (2.2s)
  -  3 [chromium] › playground.spec.ts:11:7 › Playground › Accessibility
  -  4 [chromium] › playground.spec.ts:[15](https://github.com/typescript-eslint/typescript-eslint/actions/runs/5777607577/job/15658032893?pr=7431#step:8:16):7 › Playground › Usage
  -  5 [chromium] › playground.spec.ts:51:7 › Playground › AST Viewer
  ✓  6 [chromium] › rules.spec.ts:9:7 › Rules Page › Accessibility (11.6s)
  ✓  7 [chromium] › rules.spec.ts:13:7 › Rules Page › Rules filters are saved to the URL (3.3s)
  ✓  8 [chromium] › rules.spec.ts:23:7 › Rules Page › Rules filters are read from the URL on page load (2.8s)


  1) [chromium] › index.spec.ts:15:7 › Website › Axe ───────────────────────────────────────────────

    Test timeout of 30000ms exceeded.

    Error: page.goto: Navigation failed because page was closed!
    =========================== logs ===========================
    navigating to "http://localhost:3000/", waiting until "load"
    ============================================================

      14 |
      15 |   test('Axe', async ({ page }) => {
    > 16 |     await page.goto('/');
         |                ^
      17 |     await new AxeBuilder({ page }).analyze();
      18 |   });
      19 |

        at /home/runner/work/typescript-eslint/typescript-eslint/packages/website/tests/index.spec.ts:16:16

    Pending operations:
      - page.goto at tests/index.spec.ts:16:16


  1 failed
    [chromium] › index.spec.ts:15:7 › Website › Axe ────────────────────────────────────────────────
  3 skipped
  4 passed (52.7s)

The fact that 4 passed is encouraging... but why is this one failing?
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs bug Something isn't working accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Aug 6, 2023
@rubiesonthesky
Copy link
Contributor

Not again :(

We could try this same change in page.goto method? https://github.com/typescript-eslint/typescript-eslint/pull/7363/files#

@JoshuaKGoldberg JoshuaKGoldberg added the tests anything to do with testing label Aug 7, 2023
@rubiesonthesky rubiesonthesky mentioned this issue Aug 7, 2023
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 17, 2023
Closed
1 task
@rubiesonthesky
Copy link
Contributor

I think #7638 may have fixed this but needs more monitoring :)

@JoshuaKGoldberg
Copy link
Member Author

Oh, right, we removed website tests altogether!

@JoshuaKGoldberg JoshuaKGoldberg closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working repo maintenance things to do with maintenance of the repo, and not with code/docs tests anything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: website test: use waitUntil domcontentloaded rubiesonthesky/typescript-eslint
2 participants
@rubiesonthesky @JoshuaKGoldberg
0