8000 Repo: Sponsor image 404s cause website tests to fail · Issue #7332 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Repo: Sponsor image 404s cause website tests to fail #7332

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Jul 27, 2023 · 0 comments · Fixed by #7363
Closed

Repo: Sponsor image 404s cause website tests to fail #7332

JoshuaKGoldberg opened this issue Jul 27, 2023 · 0 comments · Fixed by #7363
Labels
accepting prs Go ahead, send a pull request that resolves this issue package: website Issues related to the @typescript-eslint website repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Irksome. Example in https://github.com/typescript-eslint/typescript-eslint/actions/runs/5670711873/job/15366549313:

  1) [chromium] › index.spec.ts:10:7 › Website › should have no errors ─────────────────────────────

    Error: expect(received).toStrictEqual(expected) // deep equality

    - Expected  - 1
    + Received  + 3

    - Array []
    + Array [
    +   "[error] Failed to load resource: the server responded with a status of 404 ()",
    + ]

The issue is that a sponsor's image is a 404 and our sponsors.json file hasn't been updated yet.

Fixed by @rubiesonthesky in #7247's packages/website/tests/index.spec.ts changes: https://github.com/typescript-eslint/typescript-eslint/pull/7247/files#diff-227115ad1ec8da7528470f6ee7b0b0d9bd3adec565656c2fffedc27274cf7ac8

test.beforeEach(async ({ context }) => {
  // Sponsor logos are sometimes changed or removed between deploys
  await context.route('https://images.opencollective.com/**/*.png', route =>
    route.fulfill({
      status: 200,
      body: '',
    }),
  );
});
@JoshuaKGoldberg JoshuaKGoldberg added repo maintenance things to do with maintenance of the repo, and not with code/docs accepting prs Go ahead, send a pull request that resolves this issue package: website Issues related to the @typescript-eslint website labels Jul 27, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jul 27, 2023
Merged
3 tasks
@rubiesonthesky rubiesonthesky mentioned this issue Jul 28, 2023
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue package: website Issues related to the @typescript-eslint website repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: playwright test: ignore sponsor logo returning 404 rubiesonthesky/typescript-eslint
1 participant
@JoshuaKGoldberg
0