8000 [class-name-casing] apply same rules on type alias · Issue #671 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content
8000

[class-name-casing] apply same rules on type alias #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hotell opened this issue Jul 4, 2019 · 2 comments · Fixed by #1318
Closed

[class-name-casing] apply same rules on type alias #671

Hotell opened this issue Jul 4, 2019 · 2 comments · Fixed by #1318
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule has pr there is a PR raised to close this package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@Hotell
Copy link
Contributor
Hotell commented Jul 4, 2019 •
edited
Loading

Currently class-name-casing applies only for class and interface. It would be nice ( for consistent codebase ) to apply this rule also on type. probably enum should use this as well.

Maybe it should be extracted to separate rule as class-name-casing is too confusing by it's name.
Suggested rule rename/new name (for interface/type/enum) -> types-casing

Expected Result

// LINT ERROR
type user = {
  name: string
  age: number
}

Actual Result

// NO LINT ERROR 🥺
type user = {
  name: string
  age: number
}
@Hotell Hotell added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Jul 4, 2019
@bradzacher bradzacher added enhancement: new plugin rule New rule request for eslint-plugin and removed triage Waiting for team members to take a look labels Jul 5, 2019
@bradzacher bradzacher added this to the 3.0.0 milestone Aug 2, 2019
@bradzacher bradzacher mentioned this issue Aug 2, 2019
Merged
@j-f1
Copy link
Contributor
j-f1 commented Aug 2, 2019

symbol-name-casing or something similar since that’s the term for all these things?

@bradzacher bradzacher added enhancement: plugin rule option New rule option for an existing eslint-plugin rule and removed enhancement: new plugin rule New rule request for eslint-plugin labels Aug 2, 2019
@Hotell
Copy link
Contributor Author
Hotell commented Aug 4, 2019

symbol-name-casing or something similar since that’s the term for all these things?
. hmm symbol can mean various things right? in JS terminology ->Symbol` primitive type, in TS terminology -> inert entities => types

I'm not picky on name, rather than having the described functionality 🙏

@bradzacher bradzacher removed this from the 3.0.0 milestone Dec 3, 2019
@bradzacher bradzacher added the has pr there is a PR raised to close this label Dec 9, 2019
@bradzacher bradzacher mentioned this issue Dec 9, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule has pr there is a PR raised to close this package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint-plugin): add rule naming-conventions typescript-eslint/typescript-eslint
3 participants
@Hotell @bradzacher @j-f1
0