Bug: type-utils > TypeOrValueSpecifier doesn't account for org-scoped packages

Before You File a Proposal Please Confirm You Have Done The Following...

I have searched for related issues and found none that match my proposal.
I have searched the current rule list and found no rules that match my proposal.
I have read the FAQ and my problem is not listed.

7FC4 Relevant Package

ast-spec

My proposal is suitable for this project

I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

From #4436 (comment): when checking whether a 'package' matches in TypeOrValueSpecifier.ts, we check whether the declaration file name includes specifier.package directly:

typescript-eslint/packages/type-utils/src/TypeOrValueSpecifier.ts

Lines 170 to 176 in 346fdbc

    
           return declarationFiles.some( 
        
             declaration => 
        
               declaration.fileName.includes(`node_modules/${specifier.package}/`) || 
        
               declaration.fileName.includes( 
        
                 `node_modules/@types/${specifier.package}/`, 
        
               ), 
        
           );

This is a potential issue because package names with @ in them have a __ replacing the @. And there might be other replacements I'm not remembering - haven't looked deeply into it.

https://github.com/DefinitelyTyped/DefinitelyTyped/tree/cc222f340546ff85b7c9271f4ecbd07b9d661c94/types/11ty__eleventy-img

We should handle any name substitutions in npm packages well, and add unit tests for it in TypeOrValueSpecifier.test.ts.

Fail

n/a

Pass

n/a

Additional Info

No response

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Before You File a Proposal Please Confirm You Have Done The Following...

7FC4 Relevant Package

My proposal is suitable for this project

Description

Fail

Pass

Additional Info

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	return declarationFiles.some(
	declaration =>
	declaration.fileName.includes(`node_modules/${specifier.package}/`) \|\|
	declaration.fileName.includes(
	`node_modules/@types/${specifier.package}/`,
	),
	);

Uh oh!

Description

Before You File a Proposal Please Confirm You Have Done The Following...

7FC4 Relevant Package

My proposal is suitable for this project

Description

Fail

Pass

Additional Info

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions