8000 [indent] Incorrect indentation expected for multi-line decorated parameters · Issue #640 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

[indent] Incorrect indentation expected for multi-line decorated parameters #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
affanshahid opened this issue Jun 22, 2019 · 1 comment
Closed

[indent] Incorrect indentation expected for multi-line decorated parameters #640

affanshahid opened this issue Jun 22, 2019 · 1 comment
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Milestone
indent rewrite

Comments

@affanshahid
Copy link

Repro

{
  "rules": {
    "indent": "off",
    "@typescript-eslint/indent": [
        "error",
        2
    ],
  }
}
const log = function (target: Object, method: string, index: number) {
  console.log('decorating %s[%d]', method, index);
}


export class ProgramsController {
  getProgramById(
    @log
    id: string, // error shows up on this line
  ) {
    return this.programsService.getProgramById(id);
  }
}

Expected Result
No indentation errors
Actual Result
Expected indentation of 6 spaces but found 4. eslint(@typescript-eslint/indent)
Additional Info

Versions

package version
@typescript-eslint/eslint-plugin 1.10.2
@typescript-eslint/parser 1.10.2
TypeScript 3.5.2
ESLint 5.16.0
node 12.2.0
npm 6.9.0
@affanshahid affanshahid added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Jun 22, 2019
@bradzacher bradzacher added bug Something isn't working and removed triage Waiting for team members to take a look labels Jun 23, 2019
@bradzacher bradzacher added this to the indent rewrite milestone Jun 23, 2019
@bradzacher
Copy link
Member

Merging into #1824

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
indent rewrite
Development

No branches or pull requests
2 participants
@bradzacher @affanshahid
0