8000 Utils: remove `eslint-scope` types · Issue #4953 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Utils: remove eslint-scope types #4953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bradzacher opened this issue May 10, 2022 · 1 comment
Closed

Utils: remove eslint-scope types #4953

bradzacher opened this issue May 10, 2022 · 1 comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released enhancement New feature or request package: utils Issues related to the @typescript-eslint/utils package
Milestone
6.0.0

Comments

@bradzacher
Copy link
Member
bradzacher commented May 10, 2022 •
edited
Loading

eslint-scope has switched to use package.json exports - meaning we can no longer deep import the various bits of their codebase. The export we currently have in utils is to add types to the package which are augmented with our TSESTree types.

Because of this breaking change we cannot provide these types any more.
The reason I never removed eslint-scope from utils originally was laziness... People can use our scope-manager package instead - which is a proper fork (/ rewrite) of eslint-scope, rather than just a hackily typed and exported version.

Fail

import {TSESLintScope} from '@typescript-eslint/utils';

Pass

import * as TSESLintScope from '@typescript-eslint/scope-manager';
@bradzacher bradzacher added enhancement New feature or request breaking change This change will require a new major version to be released package: utils Issues related to the @typescript-eslint/utils package accepting prs Go ahead, send a pull request that resolves this issue labels May 10, 2022
@bradzacher bradzacher added this to the 6.0.0 milestone May 10, 2022
@bradzacher bradzacher mentioned this issue May 10, 2022
Merged
< 8000 /div>
@bradzacher
Copy link
Member Author

duplicate of #4041 oops

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released enhancement New feature or request package: utils Issues related to the @typescript-eslint/utils package
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
1 participant
@bradzacher
0