[no-shadow.ignoreTypeValueShadow] false positive against imported types #3862
Labels
bug
Something isn't working
package: eslint-plugin
Issues related to @typescript-eslint/eslint-plugin
Comments
|
This occurs because "type only" imports are actually treated as both a type and value by TS. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Repro
{ "rules": { "@typescript-eslint/no-shadow": [ "error", { "ignoreTypeValueShadow": true } ] } }tsconfig:
{ "extends": "@tsconfig/node16/tsconfig.json", "compileOnSave": true, "compilerOptions": { "baseUrl": "./", "composite": true, "esModuleInterop": true, "exactOptionalPropertyTypes": true, "experimentalDecorators": true, "forceConsistentCasingInFileNames": true, "importHelpers": true, "isolatedModules": true, "module": "ESNext", "moduleResolution": "node", "noEmit": true, "noImplicitAny": true, "noImplicitOverride": true, "noImplicitReturns": true, "noImplicitThis": true, "noUncheckedIndexedAccess": true, "noUnusedLocals": true, "paths": { "@applications/*": ["src/applications/*"], "@modules/*": ["src/modules/*"], "package.json": ["package.json"] }, "resolveJsonModule": true, "rootDirs": [".", "src/modules/seams"], "strict": true, "typeRoots": ["src/modules/@types", "node_modules/@types"] }, "exclude": ["**/node_modules", "**/build", "**/dist"], "include": ["src/**/*", "./*", "./*.json", "config/*", "config/*.json"] }Expected Result
rule should ignore imported types just like it ignores types defined in the file
Versions
@typescript-eslint/eslint-plugin4.31.0@typescript-eslint/parser4.31.0TypeScript4.4.2ESLint7.32.0node16.8.0The text was updated successfully, but these errors were encountered: