8000 Regression: no-unused-vars failing on destructured/rest/spread props · Issue #179 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Regression: no-unused-vars failing on destructured/rest/spread props #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
milesj opened this issue Feb 1, 2019 · 2 comments
Closed

Regression: no-unused-vars failing on destructured/rest/spread props #179

milesj opened this issue Feb 1, 2019 · 2 comments
Labels
package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look

Comments

@milesj
Copy link
Contributor
milesj commented Feb 1, 2019

This worked in 1.1.0 but has regressed in 1.1.1. I've noticed this primarily errors in tsx files and not ts.

Repro

Destructured vars used as props.

screen shot 2019-01-31 at 22 32 59

/Users/Miles/Sites/interweave/packages/emoji-picker/src/Picker.tsx
  749:7  error  'autoFocus' is assigned a value but never used          @typescript-eslint/no-unused-vars
  749:7  error  'autoFocus' is assigned a value but never used          no-unused-vars
  750:7  error  'clearIcon' is assigned a value but never used          no-unused-vars
  750:7  error  'clearIcon' is assigned a value but never used          @typescript-eslint/no-unused-vars
  751:7  error  'columnCount' is assigned a value but never used        @typescript-eslint/no-unused-vars
  751:7  error  'columnCount' is assigned a value but never used        no-unused-vars
  752:7  error  'commonMode' is assigned a value but never used         no-unused-vars
  752:7  error  'commonMode' is assigned a value but never used         @typescript-eslint/no-unused-vars
  758:7  error  'emojiLargeSize' is assigned a value but never used     @typescript-eslint/no-unused-vars
  758:7  error  'emojiLargeSize' is assigned a value but never used     no-unused-vars
  759:7  error  'emojiPadding' is assigned a value but never used       no-unused-vars
  759:7  error  'emojiPadding' is assigned a value but never used       @typescript-eslint/no-unused-vars
  760:7  error  'emojiPath' is assigned a value but never used          @typescript-eslint/no-unused-vars
  760:7  error  'emojiPath' is assigned a value but never used          no-unused-vars
  761:7  error  'emojiSize' is assigned a value but never used          no-unused-vars
  761:7  error  'emojiSize' is assigned a value but never used          @typescript-eslint/no-unused-vars
  762:7  error  'emojiSource' is assigned a value but never used        no-unused-vars
  762:7  error  'emojiSource' is assigned a value but never used        @typescript-eslint/no-unused-vars
  763:7  error  'groupIcons' is assigned a value but never used         no-unused-vars
  763:7  error  'groupIcons' is assigned a value but never used         @typescript-eslint/no-unused-vars
  764:7  error  'hideEmoticon' is assigned a value but never used       @typescript-eslint/no-unused-vars
  764:7  error  'hideEmoticon' is assigned a value but never used       no-unused-vars
  765:7  error  'hideGroupHeaders' is assigned a value but never used   @typescript-eslint/no-unused-vars
  765:7  error  'hideGroupHeaders' is assigned a value but never used   no-unused-vars
  766:7  error  'hideShortcodes' is assigned a value but never used     @typescript-eslint/no-unused-vars

Destructured and rest vars spread as props.

screen shot 2019-01-31 at 22 09 11

/Users/Miles/Sites/aesthetic/packages/core/src/Aesthetic.tsx
  332:34  error  'props' is assigned a value but never used       no-unused-vars
  332:34  error  'props' is assigned a value but never used       @typescript-eslint/no-unused-vars
  371:34  error  'props' is assigned a value but never used       no-unused-vars
  371:34  error  'props' is assigned a value but never used       @typescript-eslint/no-unused-vars
  372:17  error  'extraProps' is assigned a value but never used  no-unused-vars
  372:17  error  'extraProps' is assigned a value but never used  @typescript-eslint/no-unused-vars

Expected Result

Actual Result

Additional Info

Versions

package version
@typescript-eslint/eslint-plugin 1.1.1
@typescript-eslint/parser 1.1.1
TypeScript 3.2.4
ESLint 5.12.1
node 10.14.1
npm 6.5
@milesj milesj added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Feb 1, 2019
@milesj
Copy link
Contributor Author
milesj commented Feb 1, 2019

May have been this commit: 5e16003

@milesj
Copy link
Contributor Author
milesj commented Feb 1, 2019

Whoops saw this commit, will close. 6147de1

@milesj milesj closed this as completed Feb 1, 2019
@fbartho fbartho mentioned this issue Mar 20, 2019
Closed
@typescript-eslint typescript-eslint locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@milesj
0