8000 Repo: [no-explicit-any.test.ts] Switch auto-generated test cases to hand-written · Issue #11039 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Repo: [no-explicit-any.test.ts] Switch auto-generated test cases to hand-written #11039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Apr 9, 2025 · 3 comments
8000 Closed

Repo: [no-explicit-any.test.ts] Switch auto-generated test cases to hand-written #11039

JoshuaKGoldberg opened this issue Apr 9, 2025 · 3 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Some RuleTester tests in this repo are generated dynamically. Auto-generating tests like that can help create comprehensive test coverage for rules - but:

We'd like to move away from these auto-generated / dynamic test cases. That specifically means making all test cases passed to RuleTester be completely inline plain old JavaScript objects. No .flatMaps/.maps, no dedupeTestCases, helper functions, etc.

This issue tracks doing so for packages/eslint-plugin/tests/rules/no-explicit-any.test.ts.

Additional Info

💖
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs labels Apr 9, 2025
@dbarabashh

This comment has been minimized.

Sign in to view
@JoshuaKGoldberg

This comment has been minimized.

Sign in to view
@ronami
Copy link
Member
ronami commented Apr 15, 2025

@JoshuaKGoldberg I think this can be closed as it seems no-explicit-any.test.ts doesn't include any auto-generated test cases anymore (thanks to the recently merged #11032 ❤).

@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Apr 23, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JoshuaKGoldberg @ronami @dbarabashh
0