-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[2.4.0][Watch] Watching causes crash in eslint fix #1084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Maybe related: |
|
Actually, files in other directories have also been watched. Running directory: |
you can also use the environment variable
Yes and no. We watch all folders that typescript asks us to. And typescript asks for everything it thinks it needs to watch to keep its internal type model correct. TS will not ask us to watch much, if any of node_modules. If you're using a tool like lerna to symlink between packages within your project, then typescript will follow the symlinks in node_modules to their actual folder (I assume it's because there are bugs that can happen from watching a symlink instead of the actual folder), so you can end up with some weird looking watched directories. I'll have a look into pruning the watchers more.
See: #1080 |
I've just landed #1106, and it will be deployed to the I'd appreciate if you could take a moment to test the canary tag on your codebases, and let me know if anything isn't working as expected for your real-world codebase. |
Problem solved, thanks |
Uh oh!
There was an error while loading. Please reload this page.
Error option line:
https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/typescript-estree/src/tsconfig-parser.ts#L106
What code were you trying to parse?
// Any code
tsconfig.json:
eslintrc:
What did you expect to happen?
Can run
eslint --fix
without memory leak.What actually happened?
Run command
eslint --fix XXX.ts
, this command still runs and the memory keeps increasing.Then add noWatch, the problem solved.
Versions
@typescript-eslint/typescript-estree
2.4.0
TypeScript
3.6.4
node
10.15.3
npm
6.12.0
The text was updated successfully, but these errors were encountered: