8000 Repo: Remove never-used downlevel-dts · Issue #10506 · typescript-eslint/typescript-eslint · GitHub
[go: up one dir, main page]
Skip to content

Repo: Remove never-used downlevel-dts #10506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Dec 15, 2024 · 3 comments · Fixed by #11034
Closed

Repo: Remove never-used downlevel-dts #10506

JoshuaKGoldberg opened this issue Dec 15, 2024 · 3 comments · Fixed by #11034
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

I started making a new package for #10383 and saw that we still have downlevel-ts used for TS 4.3:

typescript-eslint/packages/utils/package.json

Line 57 in 7defffe

"postbuild": "downlevel-dts dist _ts4.3/dist --to=4.3",

But, as of v8, we only support TS 4.8 and newer:

typescript-eslint/packages/typescript-estree/src/parseSettings/warnAboutTSVersion.ts

Line 11 in 7defffe

export const SUPPORTED_TYPESCRIPT_VERSIONS = '>=4.8.4 <5.8.0';

We can raise the downlevel-ts targets, no?

Additional Info

💖
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Dec 15, 2024
@kirkwaiblinger
Copy link
Member

This sounds plausible, but... might want @JamesHenry to chime in (re https://discord.com/channels/1026804805894672454/1308616213676687451/1308769386026504212) before messing with this

@JamesHenry
Copy link
Member
JamesHenry commented Dec 17, 2024 •
edited
Loading

I discovered in #10361 that we were not actually invoking downlevel-dts at all in most cases because we were relying on npm lifecycle scripts that have not been invoked ever since we moved to modern yarn (i.e. a long time). AFAIK, nobody has complained/noticed?

@JoshuaKGoldberg JoshuaKGoldberg changed the title Repo: Bump downlevel-ts from TS 4.3 to 4.8 Repo: Remove never-used downlevel-ts Dec 30, 2024
@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Dec 30, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title Repo: Remove never-used downlevel-ts Repo: Remove never-used downlevel-dts Dec 30, 2024
@JoshuaKGoldberg
Copy link
Member Author

Heh. Amusing.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 7, 2025
Merged
3 tasks
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Apr 22, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove unused downlevel-dts JoshuaKGoldberg/typescript-eslint
3 participants
@JamesHenry @JoshuaKGoldberg @kirkwaiblinger
0