Bug: [no-unnecessary-condition] does not report unnecessary default value during object destructuring #10082
Closed as not planned
Description
Before You File a Bug Report Please Confirm You Have Done The Following...
- I have tried restarting my IDE and the issue persists.
- I have updated to the latest version of the packages.
- I have searched for related issues and found none that matched my issue.
- I have read the FAQ and my problem is not listed.
Playground Link
Repro Code
function Component({ foo = 1 }: { foo: number }) {
return foo;
}ESLint Config
module.exports = {
"rules": {
"@typescript-eslint/no-unnecessary-condition": "error"
}
}tsconfig
Expected Result
I would expect a lint error here form no-unnecessary-condition because the default value assignment can never be reached, given that foo is mandatory in the object
Actual Result
no error shown
Additional Info
The rule correctly reports an error when nullish coalesce is used instead:
function Component2(props: { foo: number }) {
const foo = props ?? 1
return foo
}
Unnecessary conditional, expected left-hand side of
??operator to be possibly null or undefined.
{ "compilerOptions": { "strictNullChecks": true } }