Should v6 warn or error when using the recommended-requiring-type-checking preset? #6528
Closed
JoshuaKGoldberg
announced in
RFCs
Replies: 1 comment 1 reply
-
|
I don't think there's much difference between throwing an error and deleting it because in either case you'll get an error. Part of me does dislike console warning because it breaks json based output - which would suck for users that can't control the transient usage of the name via configs. |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
agree, this is next major release that happens maybe once a year, and idea for major release that we can actually change stuff without backward compatibility |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
RFC
For context, in #6019 we discussed changing config names in v6. Part of that outcome is that the old
plugin:@typescript-eslint/recommended-requiring-type-checkingconfig would be renamed in v6 asplugin:@typescript-eslint/recommended-type-checked, with an alias left for easier backwards compat.Quoting @JamesHenry's #6515 (comment):
Now that I've had more time to ponder the breaking changes, I do like the idea of pressuring users to use the new config (and read the release notes). But I'm a little hesitant to hard break configs so immediately. How about we go with:
console.warncc @bradzacher
Additional Info
Any additional info...
Before you submit your RFC, please confirm the following. If any of these required steps are not taken, we may not be able to review your RFC. Help us to help you!
Beta Was this translation helpful? Give feedback.
All reactions