8000 Some removed rules are included in eslintrc.js · Issue #153 · typescript-eslint/tslint-to-eslint-config · GitHub
[go: up one dir, main page]
Skip to content

Some removed rules are included in eslintrc.js #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
paibamboo opened this issue Sep 23, 2019 · 4 comments · Fixed by #244
Closed

Some removed rules are included in eslintrc.js #153

paibamboo opened this issue Sep 23, 2019 · 4 comments · Fixed by #244
Labels
good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working
Milestone
1.0 Ready 🚀

Comments

@paibamboo
Copy link
paibamboo commented Sep 23, 2019 •
edited
Loading

🐛 Bug Report

  • tslint-to-eslint-config version: 0.2.4
  • ESLint version: None
  • Node version: 10.10.0

Actual Behavior

@typescript-eslint/no-triple-slash-reference, @typescript-eslint/prefer-interface, @typescript-eslint/no-object-literal-type-assertion, and @typescript-eslint/no-angle-bracket-type-assertion are included in eslintrc.js

Expected Behavior

Those 4 rules should not be included since they are replaced by new rules since v 2.0.0. (See list of breaking changes here)

  • @typescript-eslint/prefer-interface is replaced by @typescript-eslint/consistent-type-definitions.
  • @typescript-eslint/no-triple-slash-reference is replaced by @typescript-eslint/triple-slash-reference
  • @typescript-eslint/no-object-literal-type-assertion and @typescript-eslint/no-angle-bracket-type-assertion are combined in to one single rule @typescript-eslint/consistent-type-assertions

Reproduction

  • Clone this repo.
  • Go to project dir
  • Run npm install
  • Run npx tslint-to-eslint-config
@paibamboo paibamboo changed the title no-triple-slash-reference and prefer-interface rules are included in eslintrc.js Some removed rules are included in eslintrc.js Sep 23, 2019
@JoshuaKGoldberg
Copy link
Member

Yup, these should be replaced. Accepting PRs to fix converters!

docs/Development.md has a root overview for how to get started. Within that, docs/Architecture.md#rule-converters talks about how these converters operate.

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working hacktoberfest labels Sep 30, 2019
@KingDarBoja
Copy link
Collaborator

Hello @paibamboo,

I did a quick search on the official typescript-eslint GitHub and found these issues regarding the listed rules:

  • @typescript-eslint/prefer-interface is indeed removed but there is nothin about replacement as stated on #433 and this member comment.
  • @typescript-eslint/no-triple-slash-reference is indeed removed and replaced by triple-slash-reference as stated by the same member comment above.
  • @typescript-eslint/no-object-literal-type-assertion was not replaced, it is one of the recommended ones (check author issue on the same member comment).
  • @typescript-eslint/no-angle-bracket-type-assertion has the same behaviour as above. Also, probably it is a side effect as happened on this issue.

@paibamboo
Copy link
Author

HI @KingDarBoja, I added the breaking changes link in the post.

@KingDarBoja
Copy link
Collaborator

HI @KingDarBoja, I added the breaking changes link in the post.

Thank you, now it makes sense for me. Surely those rules will be fixed as soon as possible 🍰

@JoshuaKGoldberg JoshuaKGoldberg added this to the 1.0 Ready 🚀 milestone Oct 20, 2019
This was referenced Oct 20, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: bug Something isn't working
Projects
None yet
Milestone
1.0 Ready 🚀
Development

Successfully merging a pull request may close this issue.

[Bugfix] Replace removed rules
3 participants
@JoshuaKGoldberg @paibamboo @KingDarBoja
0