Merge pull request preactjs#696 from bmeurer/Typeof_Equals_Boolean

robertknight · web-flow · commit c9e331b222a4 · 2017-05-21T09:10:09.000+01:00
Use typeof to test booleaness.
diff --git a/src/h.js b/src/h.js
@@ -25,7 +25,7 @@ export function h(nodeName, attributes) {
 			for (i=child.length; i--; ) stack.push(child[i]);
 		}
 		else {
-			if (child===true || child===false) child = null;
+			if (typeof child==='boolean') child = null;
 
 			if ((simple = typeof nodeName!=='function')) {
 				if (child==null) child = '';
diff --git a/src/vdom/diff.js b/src/vdom/diff.js
@@ -66,7 +66,7 @@ function idiff(dom, vnode, context, mountAll, componentRoot) {
 		prevSvgMode = isSvgMode;
 
 	// empty values (null, undefined, booleans) render as empty Text nodes
-	if (vnode==null || vnode===false || vnode===true) vnode = '';
+	if (vnode==null || typeof vnode==='boolean') vnode = '';
 
 
 	// Fast case: Strings & Numbers create/update Text nodes.

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export function h(nodeName, attributes) {`
`25`	`25`	`for (i=child.length; i--; ) stack.push(child[i]);`
`26`	`26`	`}`
`27`	`27`	`else {`
`28`		`- if (child===true \|\| child===false) child = null;`
	`28`	`+ if (typeof child==='boolean') child = null;`
`29`	`29`
`30`	`30`	`if ((simple = typeof nodeName!=='function')) {`
`31`	`31`	`if (child==null) child = '';`