8000 Do not inherit BaseException · Issue #426 · twilio/twilio-python · GitHub
[go: up one dir, main page]

Skip to content
Do not inherit BaseException #426
Closed
Closed
@gavinwahl

Description

@gavinwahl

(twilio.base.obsolete.ObsoleteException](1bf8807#diff-a6f3daa0f60d54c1113e431cda41d132R5) is inheriting from BaseException, which is for fatal system errors and not intended to by extended by user code. The class should inherit from Exception. This is preventing the exception from being caught cleanly by error logging code.

Additionally, the obsolete_client code is making debugging of issues much harder than it should be, because it delays the error from import time to run time. I would much rather get an ImportError when trying to import something that has been removed.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0