8000 chore: using py-localtunnel instead of ngrok · twilio/twilio-python@164fbed · GitHub
[go: up one dir, main page]

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 164fbed

Browse files
chore: using py-localtunnel instead of ngrok
1 parent fda3a53 commit 164fbed

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

tests/cluster/test_webhook.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
import unittest
33
import time
44
import _thread
5-
import subprocess
65

76
from http.server import BaseHTTPRequestHandler, HTTPServer
7+
from py_localtunnel import LocalTunnel
88
from twilio.request_validator import RequestValidator
99
from twilio.rest import Client
1010

@@ -43,13 +43,8 @@ def setUp(self):
4343

4444
port_number = 7777
4545
self.validation_server = HTTPServer(("", port_number), RequestHandler)
46-
self.tunnel = subprocess.Popen(["jprq", "http", str(port_number)])
47-
print(self.tunnel.stderr.read())
48-
if self.tunnel.returncode:
49-
raise Exception("JPRQ failed to start")
50-
self.tunnel_url = (
51-
self.tunnel.stdout.readline().decode().strip()
52-
) # Capture the URL
46+
self.tunnel = LocalTunnel(port=port_number)
47+
self.tunnel.start()
5348
self.flow_sid = ""
5449
_thread.start_new_thread(self.start_http_server, ())
5550

@@ -58,7 +53,7 @@ def start_http_server(self):
5853

5954
def tearDown(self):
6055
self.client.studio.v2.flows(self.flow_sid).delete()
61-
self.tunnel.kill()
56+
self.tunnel.stop()
6257
self.validation_server.shutdown()
6358
self.validation_server.server_close()
6459

tests/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ django
1111
multidict
1212
black
1313
autoflake
14-
jprq
14+
py-localtunnel

0 commit comments

Comments
 (0)
0