Fix 'starts with' and 'ends with' expressions #661

ilkkave · 2019-09-23T17:16:48Z

Fixes #660

Makes starts with and ends with expressions to not throw an error with non-string values.

Changes proposed in this pull request:

Add a check for starts with and ends with expressions to check if it’s tested against a string.
Add a test case where using starts with and ends with with an undefined variable.

…tring values

RobLoach · 2019-09-24T01:30:14Z

Thanks, this will help clean up input exceptions...

Should this also work with numbers or values? Outside of just strings?

ilkkave · 2019-09-25T14:42:21Z

Should this also work with numbers or values? Outside of just strings?

I think it should only work with strings, but I can take a look how it works in Twig.

RobLoach · 2019-10-16T19:58:03Z

This is a good change in the mean time. For array support, that should likely be a new PR. Thanks!

Fix 'starts with' and 'ends with' expressions to not break with non-s…

979674e

…tring values

RobLoach merged commit a00787d into twigjs:master Oct 16, 2019

Provide feedback