allow_async twig option in expressjs doesn't work for 1.14.0 #706

dfinton · 2019-12-26T14:36:11Z

"allow_async" should allow the adding of extension functions that are defined as "async". This issue (which was resolved for 1.12.0) documents this: #553

This option appears to be broken for the latest twig release (1.14.0). When I attempt to add an async function with allow_async enabled, I get the following error: throw new Twig.Error('You are using Twig.js in sync mode in combination with async extensions.');

The following code snippet does work for Twig.js versions 1.12.0 and 1.13.3. I am running node version 12.13.1 (latest LTS), but I was also able to reproduce his behavior in node v10.

test.js

const express = require('express');
const twig = require('twig');

const app = express();

const testAsync = async () => {
  const testPromise = new Promise(resolve => {
    resolve('Hello World');
  });

  const testResult = await testPromise;

  return testResult;
};

app.set('view engine', 'twig');

app.set('twig options', { 
    allow_async: true,
    strict_variables: false
});

twig.extendFunction('testAsync', testAsync);

app.get('/test', (req, res) => {
  res.render('test.html.twig');
});

app.listen(3000);

views/test.html.twig

<html>
  <head>
    <title>ASync Test</title>
  </head>
  <body>
    <h1>This is a test of an ASync function</h1>
    <p>
      {% set myVal = testAsync() %}
      {{ myVal }}
    </p>
  </body>
</html>

The text was updated successfully, but these errors were encountered:

dfinton · 2019-12-26T19:06:34Z

EDIT: I replaced the typescript example with vanilla javascript

JROUD · 2020-04-21T06:50:46Z

This option is now called allowAsync. Not yet fixed in the documentation.

willrowe · 2022-08-01T14:05:02Z

As @JROUD mentioned, it was renamed to allowAsync. Documentation will be updated accordingly for the next version.

willrowe added priority - high triaged pending - help wanted difficulty - low type - documentation labels Aug 1, 2022

willrowe added this to the v1.16.0 milestone Aug 1, 2022

willrowe mentioned this issue Jan 4, 2023

Fix casing of variables in docs #852

Merged

willrowe closed this as completed in #852 Jan 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow_async twig option in expressjs doesn't work for 1.14.0 #706

allow_async twig option in expressjs doesn't work for 1.14.0 #706

allow_async twig option in expressjs doesn't work for 1.14.0 #706

allow_async twig option in expressjs doesn't work for 1.14.0 #706

Comments