fix lost context when calling a macro multiple times

Mihkel Eidast · Mihkel Eidast · commit e58abd97e685 · 2020-11-13T20:17:04.000+02:00
diff --git a/src/twig.logic.js b/src/twig.logic.js
@@ -1006,6 +1006,7 @@ module.exports = function (Twig) {
                 state.macros[token.macroName] = function (...args) {
                     // Pass global context and other macros
                     const macroContext = {
+                        ...context,
                         _self: state.macros
                     };
                     // Save arguments
diff --git a/test/templates/macro-self-twice.twig b/test/templates/macro-self-twice.twig
@@ -0,0 +1,2 @@
+{% macro input(name, value, type, size) %}<input type="{{ type|default('text') }}" name="{{ name }}" value="{{ value|e }}" size="{{ size|default(20) }}" />{% endmacro %}
+{% import _self as forms %}<p>{{ forms.input('username') }}</p><p>{{ forms.input('password') }}</p>
diff --git a/test/test.macro.js b/test/test.macro.js
@@ -34,6 +34,16 @@ describe('Twig.js Macro ->', function () {
         twig({ref: 'import-macro-self'}).render({ }).trim().should.equal('<p><input type="text" name="username" value="" size="20" /></p>');
     });
 
+    it('it should run macro with self reference twice', function () {
+        twig({
+            id: 'import-macro-self-twice',
+            path: 'test/templates/macro-self-twice.twig',
+            async: false
+        });
+        // Load the template
+        twig({ref: 'import-macro-self-twice'}).render({ }).trim().should.equal('<p><input type="text" name="username" value="" size="20" /></p><p><input type="text" name="password" value="" size="20" /></p>');
+    });
+
     it('it should run wrapped macro with self reference', function () {
         twig({
             id: 'import-wrapped-macro-self',

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+{% macro input(name, value, type, size) %}<input type="{{ type\|default('text') }}" name="{{ name }}" value="{{ value\|e }}" size="{{ size\|default(20) }}" />{% endmacro %}`
	`2`	`+{% import _self as forms %}<p>{{ forms.input('username') }}</p><p>{{ forms.input('password') }}</p>`