Fix Cursor.close() to drop statement and rows

penberg · penberg · commit e9f9f59b4272 · 2025-05-01T16:13:36.000+03:00
diff --git a/src/lib.rs b/src/lib.rs
@@ -330,8 +330,24 @@ pub struct Cursor {
 // SAFETY: The libsql crate guarantees that `Connection` is thread-safe.
 unsafe impl Send for Cursor {}
 
+impl Drop for Cursor {
+    fn drop(&mut self) {
+        self.stmt.replace(None);
+        self.rows.replace(None);
+    }
+}
+
 #[pymethods]
 impl Cursor {
+    fn close(self_: PyRef<'_, Self>) -> PyResult<()> {
+        rt().block_on(async {
+            let cursor: &Cursor = &self_;
+            cursor.stmt.replace(None);
+            cursor.rows.replace(None);
+        });
+        Ok(())
+    }
+
     fn execute<'a>(
         self_: PyRef<'a, Self>,
         sql: String,
@@ -474,11 +490,6 @@ impl Cursor {
     fn rowcount(self_: PyRef<'_, Self>) -> PyResult<i64> {
         Ok(*self_.rowcount.borrow())
     }
-
-    fn close(_self: PyRef<'_, Self>) -> PyResult<()> {
-        // TODO
-        Ok(())
-    }
 }
 
 async fn begin_transaction(conn: &libsql_core::Connection) -> PyResult<()> {
