[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EAS_ENCRYPT_IV_SECRET environmental variable to helm template #134

Open
venkyhodigere opened this issue Nov 3, 2021 · 4 comments
Open

Add EAS_ENCRYPT_IV_SECRET environmental variable to helm template #134

venkyhodigere opened this issue Nov 3, 2021 · 4 comments

Comments

@venkyhodigere
Copy link

Hi there,

I wanted to use the initialization vector for the config token encryption with AES.

I saw that the support for IV is already there in utils.js
https://github.com/travisghansen/external-auth-server/blob/master/src/utils.js#L14

But the env var setup for EAS_ENCRYPT_IV_SECRET is missing in the deployment.yaml helm template:
https://github.com/travisghansen/external-auth-server/blob/master/charts/external-auth-server/templates/deployment.yaml

I was wondering if you are ok if I go ahead and add it in there and raise a PR.

Venky
@travisghansen
Copy link
Owner

Welcome!

Yeah of course! Let's get it added. Just make sure to add it as a secret value and treat it similar to how the rest of the secrets are treated.

@venkyhodigere
Copy link
Author
venkyhodigere commented Jan 5, 2022 •
edited
Loading

I have added it as a secret value.

Would it be possible to take a look at the PR: #137

@travisghansen
Copy link
Owner

Yeah I haven’t forgotten about this. Thanks for the contribution!

The holdup is I’m considering rewriting a bit of how this value is used to more closely align with its cryptographic purpose. Currently it’s just in there as a way to sort of suppress the warnings in the logs but it’s not quite what it needs to be. In that vein I’ve just been holding off a bit :(

@venkyhodigere
Copy link
Author

Please let me know if there is something I could do help with to take this forward.

Meantime, would you be ok to review/approve this PR and do the bigger redesign as a subsequent feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@travisghansen @venkyhodigere