From 8672d26a2db9696dadde15333b1e7aa48148eb13 Mon Sep 17 00:00:00 2001 From: Gal Kleinman Date: Mon, 20 May 2024 16:16:33 +0300 Subject: [PATCH 1/3] fix(manual-tracing): add missing llm.request.type attribute --- packages/traceloop-sdk/src/lib/tracing/manual.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/traceloop-sdk/src/lib/tracing/manual.ts b/packages/traceloop-sdk/src/lib/tracing/manual.ts index 7c123e75..01aa05ea 100644 --- a/packages/traceloop-sdk/src/lib/tracing/manual.ts +++ b/packages/traceloop-sdk/src/lib/tracing/manual.ts @@ -79,7 +79,7 @@ export class LLMSpan { }[]; }) { this.span.setAttributes({ - [SpanAttributes.LLM_REQUEST_MODEL]: model, + [SpanAttributes.LLM_REQUEST_MODEL]: model }); messages.forEach((message, index) => { @@ -163,6 +163,7 @@ export function withLLMCall< F extends ({ span }: { span: LLMSpan }) => ReturnType, >({ vendor, type }: LLMCallConfig, fn: F, thisArg?: ThisParameterType) { const span = getTracer().startSpan(`${vendor}.${type}`, {}, context.active()); + span.setAttribute(SpanAttributes.LLM_REQUEST_TYPE, type); trace.setSpan(context.active(), span); const res = fn.apply(thisArg, [{ span: new LLMSpan(span) }]); From a5741631298eeb8447a353308815803b99f0a22f Mon Sep 17 00:00:00 2001 From: Gal Kleinman Date: Mon, 20 May 2024 16:18:28 +0300 Subject: [PATCH 2/3] return deleted comma --- packages/traceloop-sdk/src/lib/tracing/manual.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/traceloop-sdk/src/lib/tracing/manual.ts b/packages/traceloop-sdk/src/lib/tracing/manual.ts index 01aa05ea..55c001fe 100644 --- a/packages/traceloop-sdk/src/lib/tracing/manual.ts +++ b/packages/traceloop-sdk/src/lib/tracing/manual.ts @@ -79,7 +79,7 @@ export class LLMSpan { }[]; }) { this.span.setAttributes({ - [SpanAttributes.LLM_REQUEST_MODEL]: model + [SpanAttributes.LLM_REQUEST_MODEL]: model, }); messages.forEach((message, index) => { From ba439af8e09d2b48e54923747ecb9f78835693b1 Mon Sep 17 00:00:00 2001 From: Gal Kleinman Date: Mon, 20 May 2024 16:36:56 +0300 Subject: [PATCH 3/3] adjust test as well --- packages/traceloop-sdk/test/decorators.test.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/traceloop-sdk/test/decorators.test.ts b/packages/traceloop-sdk/test/decorators.test.ts index 5a3658f4..029c7be4 100644 --- a/packages/traceloop-sdk/test/decorators.test.ts +++ b/packages/traceloop-sdk/test/decorators.test.ts @@ -415,6 +415,10 @@ describe("Test SDK Decorators", () => { workflowSpan.spanContext().spanId, ); + assert.strictEqual( + completionSpan.attributes[`${SpanAttributes.LLM_REQUEST_TYPE}`], + "chat", + ); assert.strictEqual( completionSpan.attributes[`${SpanAttributes.LLM_REQUEST_MODEL}`], "gpt-3.5-turbo",