8000 fix(sdk): update deprecations in otel (#149) · traceloop/openllmetry-js@ddfc3a2 · GitHub
[go: up one dir, main page]

Skip to content

Commit ddfc3a2

Browse files
authored
fix(sdk): update deprecations in otel (#149)
1 parent 82d82bf commit ddfc3a2

File tree

1 file changed

+4
-3
lines changed
  • packages/traceloop-sdk/src/lib/tracing

1 file changed

+4
-3
lines changed

packages/traceloop-sdk/src/lib/tracing/index.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
import { Span, context, diag } from "@opentelemetry/api";
88
import { OTLPTraceExporter } from "@opentelemetry/exporter-trace-otlp-proto";
99
import { Resource } from "@opentelemetry/resources";
10-
import { SemanticResourceAttributes } from "@opentelemetry/semantic-conventions";
10+
import { SEMRESATTRS_SERVICE_NAME } from "@opentelemetry/semantic-conventions";
1111
import { Instrumentation } from "@opentelemetry/instrumentation";
1212
import { InitializeOptions } from "../interfaces";
1313
import { ASSOCATION_PROPERTIES_KEY, WORKFLOW_NAME_KEY } from "./tracing";
@@ -291,9 +291,10 @@ export const startTracing = (options: InitializeOptions) => {
291291

292292
_sdk = new NodeSDK({
293293
resource: new Resource({
294-
[SemanticResourceAttributes.SERVICE_NAME]: options.appName,
294+
[SEMRESATTRS_SERVICE_NAME]:
295+
options.appName || process.env.npm_package_name,
295296
}),
296-
spanProcessor: _spanProcessor,
297+
spanProcessors: [_spanProcessor],
297298
traceExporter,
298299
instrumentations,
299300
// We should re-consider removing unrelevant spans here in the future

0 commit comments

Comments
 (0)
0