8000 Since getClientIp() no longer takes a parameter, removed that old test · tonypiper/symfony@85db221 · GitHub
[go: up one dir, main page]

Skip to content

Commit 85db221

Browse files
author
Neil Ferreira
committed
Since getClientIp() no longer takes a parameter, removed that old test
Added a new test for HTTP_X_FORWARDED_FOR that starts with 'unknown, '
1 parent 7b5328f commit 85db221

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/Symfony/Component/HttpFoundation/Tests/RequestTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -552,7 +552,6 @@ public function testGetClientIp($expected, $proxy, $remoteAddr, $httpClientIp, $
552552
{
553553
$request = new Request();
554554
$this->assertEquals('', $request->getClientIp());
555-
$this->assertEquals('', $request->getClientIp(true));
556555

557556
$server = array('REMOTE_ADDR' => $remoteAddr);
558557
if (null !== $httpClientIp) {
@@ -584,6 +583,7 @@ public function testGetClientIpProvider()
584583
array('2620:0:1cfe:face:b00c::3', true, '::1', '2620:0:1cfe:face:b00c::3', null),
585584
array('2620:0:1cfe:face:b00c::3', true, '::1', null, '2620:0:1cfe:face:b00c::3, ::1'),
586585
array('88.88.88.88', true, '123.45.67.89', null, '88.88.88.88, 87.65.43.21, 127.0.0.1'),
586+
array('88.88.88.88', true, '123.45.67.89', null, 'unknown, 88.88.88.88'),
587587
);
588588
}
589589

0 commit comments

Comments
 (0)
0