8000 minor #36546 [Mailer] Add a comment to avoid more wrong PRs on this p… · tomasjav/symfony@bbbf80f · GitHub
[go: up one dir, main page]
Skip to content

Commit bbbf80f

Browse files
fabpotfabpot
committed
minor symfony#36546 [Mailer] Add a comment to avoid more wrong PRs on this piece of code (fabpot)
This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Add a comment to avoid more wrong PRs on this piece of code | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Numerous bogus PRs <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | n/a Commits ------- 444e616 [Mailer] Add a comment to avoid more wrong PRs on this piece of code
2 parents 119ba3b + 444e616 commit bbbf80f

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

‎src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransport.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,9 @@ protected function doHeloCommand(): void
106106

107107
/** @var SocketStream $stream */
108108
$stream = $this->getStream();
109+
// WARNING: !$stream->isTLS() is right, 100% sure :)
110+
// if you think that the ! should be removed, read the code again
111+
// if doing so "fixes" your issue then it probably means your SMTP server behaves incorrectly or is wrongly configured
109112
if (!$stream->isTLS() && \defined('OPENSSL_VERSION_NUMBER') && \array_key_exists('STARTTLS', $capabilities)) {
110113
$this->executeCommand("STARTTLS\r\n", [220]);
111114

0 commit comments

Comments
 (0)
0