Promote PyYaml to a direct dependency#833
Merged
tony merged 2 commits intotmux-python:masterfrom Oct 8, 2022
heindsight:yaml-dep
Merged
Promote PyYaml to a direct dependency#833tony merged 2 commits intotmux-python:masterfrom heindsight:yaml-dep
tony merged 2 commits intotmux-python:masterfrom
heindsight:yaml-dep
Conversation
Member
|
@heindsight This makes sense and we need to do this now kaptan is removed (#828) I will fast track this |
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
=======================================
Coverage 75.45% 75.45%
=======================================
Files 19 19
Lines 1434 1434
Branches 331 331
=======================================
Hits 1082 1082
Misses 265 265
Partials 87 87 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
After installing in a fresh Python virtual environment, `tmuxp` fails with `ModuleNotFoundError: No module named 'yaml'`. This happens because since switching from `kaptan` to `ConfigReader`, `PyYaml` is no longer pulled in as a transitive dependency. Adding `PyYaml` as a direct "main" dependency should fix this.
Contributor
Author
|
Thanks @tony |
Member
|
@heindsight vice versa Bikeshed: Do these pins matter to you? (I don't have python 3.11 on my system quite yet) When I run diff --git a/poetry.lock b/poetry.lock
index ed9b1b0..c2b28b8 100644
--- a/poetry.lock
+++ b/poetry.lock
@@ -1420,13 +1420,6 @@ PyYAML = [
{file = "PyYAML-6.0-cp310-cp310-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_12_x86_64.manylinux2010_x86_64.whl", hash = "sha256:f84fbc98b019fef2ee9a1cb3ce93e3187a6df0b2538a651bfb890254ba9f90b5"},
{file = "PyYAML-6.0-cp310-cp310-win32.whl", hash = "sha256:2cd5df3de48857ed0544b34e2d40e9fac445930039f3cfe4bcc592a1f836d513"},
{file = "PyYAML-6.0-cp310-cp310-win_amd64.whl", hash = "sha256:daf496c58a8c52083df09b80c860005194014c3698698d1a57cbcfa182142a3a"},
- {file = "PyYAML-6.0-cp311-cp311-macosx_10_9_x86_64.whl", hash = "sha256:d4b0ba9512519522b118090257be113b9468d804b19d63c71dbcf4a48fa32358"},
- {file = "PyYAML-6.0-cp311-cp311-macosx_11_0_arm64.whl", hash = "sha256:81957921f441d50af23654aa6c5e5eaf9b06aba7f0a19c18a538dc7ef291c5a1"},
- {file = "PyYAML-6.0-cp311-cp311-manylinux_2_17_aarch64.manylinux2014_aarch64.whl", hash = "sha256:afa17f5bc4d1b10afd4466fd3a44dc0e245382deca5b3c353d8b757f9e3ecb8d"},
- {file = "PyYAML-6.0-cp311-cp311-manylinux_2_17_s390x.manylinux2014_s390x.whl", hash = "sha256:dbad0e9d368bb989f4515da330b88a057617d16b6a8245084f1b05400f24609f"},
- {file = "PyYAML-6.0-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl", hash = "sha256:432557aa2c09802be39460360ddffd48156e30721f5e8d917f01d31694216782"},
- {file = "PyYAML-6.0-cp311-cp311-win32.whl", hash = "sha256:bfaef573a63ba8923503d27530362590ff4f576c626d86a9fed95822a8255fd7"},
- {file = "PyYAML-6.0-cp311-cp311-win_amd64.whl", hash = "sha256:01b45c0191e6d66c470b6cf1b9531a771a83c1c4208272ead47a3ae4f2f603bf"},
{file = "PyYAML-6.0-cp36-cp36m-macosx_10_9_x86_64.whl", hash = "sha256:897b80890765f037df3403d22bab41627ca8811ae55e9a722fd0392850ec4d86"},
{file = "PyYAML-6.0-cp36-cp36m-manylinux_2_17_aarch64.manylinux2014_aarch64.whl", hash = "sha256:50602afada6d6cbfad699b0c7bb50d5ccffa7e46a3d738092afddc1f9758427f"},
{file = "PyYAML-6.0-cp36-cp36m-manylinux_2_17_s390x.manylinux2014_s390x.whl", hash = "sha256:48c346915c114f5fdb3ead70312bd042a953a8ce5c7106d5bfb1a5254e47da92"}, |
Member
|
@heindsight This is live in https://pypi.org/project/tmuxp/1.16.2/ Better now? |
Contributor
Author
No, they're not important to me at all. They were automatically added when I ran
Much better. Thanks 👍 |
Member
Noted, and excellent it's working now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After installing in a fresh Python virtual environment,
tmuxpfails withModuleNotFoundError: No module named 'yaml'. This happens because since switching fromkaptantoConfigReader,PyYamlis no longer pulled in as a transitive dependency. AddingPyYamlas a direct "main" dependency should fix this.