When loading, get the config canonical file path#236
Merged
tony merged 2 commits intotmux-python:masterfrom Apr 26, 2017
rafi:fix/symlinks
Merged
When loading, get the config canonical file path#236tony merged 2 commits intotmux-python:masterfrom rafi:fix/symlinks
tony merged 2 commits intotmux-python:masterfrom
rafi:fix/symlinks
Conversation
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=========================================
- Coverage 83.68% 83.6% -0.09%
=========================================
Files 5 5
Lines 754 750 -4
=========================================
- Hits 631 627 -4
Misses 123 123
Continue to review full report at Codecov.
|
Member
|
@rafi Thank for you this, can you try adding a test? You can use https://py.readthedocs.io/en/latest/path.html#py._path.local.LocalPath.mksymlinkto to make a symlink with pytest. Example: https://github.com/pytest-dev/pytest/blob/6c8b0/testing/test_tmpdir.py#L88 |
Contributor
Author
|
@tony thanks for the pointers, added a test. |
Fix issue when config files are symlinks in `~/.tmuxp`
Member
|
This is now live in v1.3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue when config files are symlinks in
~/.tmuxp.For example,
Once loaded, it is expected for
/Users/bob/code/python/hooray/...to be the current directory, specially when usingstart_directory: ./within the configuration file.Before this patch, the current directory will improperly resolve to
/Users/bob/.tmuxp.