8000 Add session id to Session cmds, when appropriate by askedrelic · Pull Request #65 · tmux-python/libtmux · GitHub
[go: up one dir, main page]
Skip to content

Add session id to Session cmds, when appropriate #65

Merged
tony merged 4 commits intotmux-python:masterfrom
askedrelic:add-kwargs-to-tmux-cmd
Aug 18, 2017
Merged

Add session id to Session cmds, when appropriate #65
tony merged 4 commits intotmux-python:masterfrom
askedrelic:add-kwargs-to-tmux-cmd

Conversation

@askedrelic
Copy link
Contributor
@askedrelic askedrelic commented Aug 8, 2017 •
edited
Loading

Starting on fixing #64.

@tony
Copy link
Member
tony commented Aug 9, 2017

Let's try to take the approach where we smooth out the *args (#64 (comment)). We can use += instead of .extends( to avoid an extra function call (#64 (comment)).

@askedrelic askedrelic force-pushed the add-kwargs-to-tmux-cmd branch from 541ad0c to 22f7ea8 Compare August 15, 2017 20:36
@askedrelic
Copy link
Contributor Author
askedrelic commented Aug 15, 2017

So I rebased my code to use += to add the session id, if it is not set. It's a little more complicated due to tmux requiring the -t arg be in a specific position, but the test suite should be passing!

@askedrelic askedrelic changed the title Working adding kwargs to tmux_cmd Add session id to Session cmds, when appropriate Aug 15, 2017
@askedrelic
Copy link
Contributor Author
askedrelic commented Aug 16, 2017

Hmm looks like tests broke due to Py3. I'm still using Py2 as my main environment, I will take a look!

@codecov-io
Copy link
codecov-io commented Aug 16, 2017 •
edited
Loading

Codecov Report

Merging #65 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   79.97%   80.07%   +0.09%     
==========================================
  Files           8        8              
  Lines         844      848       +4     
==========================================
+ Hits          675      679       +4     
  Misses        169      169
Impacted Files Coverage Δ
libtmux/session.py 81.09% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6df234...a9bf0a5. Read the comment docs.

@tony tony merged commit 6811ba4 into tmux-python:master Aug 18, 2017
@tony tony mentioned this pull request Aug 18, 2017
Closed
@tony
Copy link
Member
tony commented Aug 18, 2017

@askedrelic nice job!

@askedrelic
Copy link
Contributor Author
askedrelic commented Aug 19, 2017

Hooray, thanks for the merge @tony 🎊

@askedrelic askedrelic deleted the add-kwargs-to-tmux-cmd branch August 19, 2017 08:03
@askedrelic askedrelic mentioned this pull request Aug 19, 2017
Closed
@tony
Copy link
Member
tony commented Aug 20, 2017

released in v0.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@askedrelic @tony @codecov-io
0