ci: Remove setuptools requirement for build-system#495
Merged
Conversation
This may impact package maintainer downstream. See also: python-poetry/poetry#34 (comment)
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
=======================================
Coverage 88.97% 88.97%
=======================================
Files 35 35
Lines 3484 3484
Branches 484 484
=======================================
Hits 3100 3100
Misses 276 276
Partials 108 108 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may impact package maintainers downstream.
Resolves #493, #494
See also:
build(build-system): Remove setuptools build dependency #493
Due to CLA being refused by pull requester I've cut my own PR by hand. I've never not had a CLA refused to be signed by a pull requester, but if it happens in the future for a non-trivial pull requests we can devise a best practice.
pip install -e . equivalent? python-poetry/poetry#34 (comment)