Conversation
3d66aa4 to
87153fd
Compare
87153fd to
44950da
Compare
________________________ ERROR collecting test session _________________________ Defining 'pytest_plugins' in a non-top-level conftest is no longer supported: It affects the entire test suite instead of just below the conftest as expected. /home/runner/work/libtmux/libtmux/src/libtmux/conftest.py Please move it to a top level conftest file at the rootdir: /home/runner/work/libtmux/libtmux For more information, visit: https://docs.pytest.org/en/stable/deprecations.html#pytest-plugins-in-non-top-level-conftest-files
conftest.py: error: Duplicate module named "conftest" (also at "docs/conftest.py")
I still have to run locals().keys() to scope request into the doctest context, no idea why.
The request context isn't detected inside the doctest unless I run locals(). The request context is needed to join the example code's import so the type annotation shows.
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
==========================================
- Coverage 86.34% 86.30% -0.04%
==========================================
Files 22 23 +1
Lines 1824 1826 +2
Branches 277 277
==========================================
+ Hits 1575 1576 +1
- Misses 170 171 +1
Partials 79 79
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
1466057 to
399f3a5
Compare
8ad5ec4 to
adbcd0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #438