8000 Add start_directory to support to new sessions and panes by gandelman-a · Pull Request #19 · tmux-python/libtmux · GitHub
[go: up one dir, main page]
Skip to content

Add start_directory to support to new sessions and panes#19

Merged
tony merged 1 commit intotmux-python:masterfrom
gandelman-a:master
Dec 20, 2016
Merged

Add start_directory to support to new sessions and panes#19
tony merged 1 commit intotmux-python:masterfrom
gandelman-a:master

Conversation

@gandelman-a
Copy link
Contributor
@gandelman-a gandelman-a commented Dec 19, 2016

This allows specifying start_directory for creation of both
session and panes.

Clarifies some docstrings as well.

@gandelman-a
Add start_directory to support to new sessions and panes
5518068 
This allows specifying start_directory for creation of both
session and panes.

Clarifies some docstrings as well.
@codecov-io
Copy link
codecov-io commented Dec 19, 2016 •
edited
Loading

Current coverage is 78.25% (diff: 66.66%)

Merging #19 into master will decrease coverage by 0.06%

@@             master        #19   diff @@
==========================================
  Files             8          8          
  Lines           812        814     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            636        637     +1   
- Misses          176        177     +1   
  Partials          0          0

Powered by Codecov. Last update 5c227e6...5518068

@tony
Copy link
Member
tony commented Dec 20, 2016

Looks good to me, 👍

@tony tony merged commit d991e69 into tmux-python:master Dec 20, 2016
@tony
Copy link
Member
tony commented Dec 20, 2016 •
edited
Loading

@gandelman-a do you need this published ASAP? I can tag a new version w/ this PR

@gandelman-a
Copy link
Contributor Author
gandelman-a commented Dec 20, 2016

Hi Tony, no.. thats fine. Just setting up some scripts for my dev. env. and running from master so its fine. Thanks!

@tony
Copy link
Member
tony commented Dec 21, 2016

Understood. This got released in 0.6.1 too

@tony
Copy link
Member
tony commented Dec 21, 2016

thanks for the contribution again @gandelman-a ! nicely done!

@haakenlid
Copy link
haakenlid commented Jan 12, 2017

tmux version 1.8 doesn't support the tmux new-session -c <start_directory> option. This caused an error in the tmuxp tests.

https://travis-ci.org/tony/tmuxp/jobs/190761397#L917
E LibTmuxException: [u'tmux: unknown option -- c', u'usage: new-session [-AdDP] [-F format] [-n window-name] [-s session-name] [-t target-session] [-x width] [-y height] [command]']

A possible workaround is to instead use default-path in tmux 1.8 (not supported in later versions) or to use subprocess to run something like this (cd $start_directory; tmux new-session -t $session_name), which should work in all versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gandelman-a @codecov-io @tony @haakenlid
0