8000 fix exception raised at RTCPeerConnection.removeTrack and RTCRtpSende… · tmthecoder/flutter-webrtc@72b6be9 · GitHub
[go: up one dir, main page]
Skip to content

Commit 72b6be9

Browse files
jjpark-editojjpark-edito
authored
fix exception raised at RTCPeerConnection.removeTrack and RTCRtpSender.setParameters (flutter-webrtc#588)
1 parent 6e25b75 commit 72b6be9

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

‎lib/src/web/rtc_peerconnection_impl.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,8 @@ class RTCPeerConnectionWeb extends RTCPeerConnection {
330330
Future<bool> removeTrack(RTCRtpSender sender) async {
331331
var nativeSender = sender as RTCRtpSenderWeb;
332332
// var nativeTrack = nativeSender.track as MediaStreamTrackWeb;
333-
return jsutil.callMethod(_jsPc, 'removeTrack', [nativeSender.jsRtpSender]);
333+
jsutil.callMethod(_jsPc, 'removeTrack', [nativeSender.jsRtpSender]);
334+
return Future<bool>.value(true);
334335
}
335336

336337
@override

‎lib/src/web/rtc_rtp_sender_impl.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,9 @@ class RTCRtpSenderWeb extends RTCRtpSender {
5959
'encodings',
6060
jsutil.jsify(
6161
parameters.encodings?.map((e) => e.toMap()).toList() ?? []));
62-
return await jsutil.promiseToFuture<bool>(
62+
await jsutil.promiseToFuture<void>(
6363
jsutil.callMethod(_jsRtpSender, 'setParameters', [oldParameters]));
64+
return Future<bool>.value(true);
6465
} on PlatformException catch (e) {
6566
throw 'Unable to RTCRtpSender::setParameters: ${e.message}';
6667
}

0 commit comments

Comments
 (0)
0