Unify specifying label in attributes_table component (activeadmin#8458)

mgrunberg · web-flow · commit b87754a78fa0 · 2024-08-27T14:08:13.000-03:00
* Unify specifying label in show -> attributes_table closes activeadmin#3359, closes activeadmin#167 * add specs
diff --git a/lib/active_admin/views/components/attributes_table.rb b/lib/active_admin/views/components/attributes_table.rb
@@ -23,6 +23,7 @@ def rows(*attrs)
 
       def row(*args, &block)
         title = args[0]
+        data = args[1] || args[0]
         options = args.extract_options!
         options["data-row"] = title.to_s.parameterize(separator: "_") if title.present?
 
@@ -32,7 +33,7 @@ def row(*args, &block)
           end
           @collection.each do |record|
             td do
-              content_for(record, block || title)
+              content_for(record, block || data)
             end
           end
         end
diff --git a/spec/unit/views/components/attributes_table_spec.rb b/spec/unit/views/components/attributes_table_spec.rb
@@ -47,6 +47,15 @@
           end
         end
       },
+      "when you create each row with a string and symbol" => proc {
+        render_arbre_component(assigns) do
+          attributes_table_for post do
+            row "Id", :id
+            row "Title", :title
+            row "Body", :body
+          end
+        end
+      },
       "when you create each row with a custom block that returns nil" => proc {
         render_arbre_component(assigns) do
           attributes_table_for post do
