cmake: setup required libraries before checking function

tiennou · tiennou · commit df2ff6fbe290 · 2018-03-30T00:16:18.000+02:00
As per the docs[1], another set of variables will be provided by PKG_CHECK_MODULES when static linking (with the additional libraries required for static links). We need to pass those libraries to CHECK_LIBRARY_EXISTS so *its* link succeeds. 1 - https://cmake.org/cmake/help/v3.1/module/FindPkgConfig.html#command:pkg_check_modules Ref: libgit2/objective-git#645
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -292,7 +292,18 @@ IF (LIBSSH2_FOUND)
 	LIST(APPEND LIBGIT2_PC_LIBS ${LIBSSH2_LDFLAGS})
 	#SET(LIBGIT2_PC_LIBS "${LIBGIT2_PC_LIBS} ${LIBSSH2_LDFLAGS}")
 
-	CHECK_LIBRARY_EXISTS("${LIBSSH2_LIBRARIES}" libssh2_userauth_publickey_frommemory "${LIBSSH2_LIBRARY_DIRS}" HAVE_LIBSSH2_MEMORY_CREDENTIALS)
+	# We might need to provide additional libraries so libssh2 links
+	SET(CMAKE_REQUIRED_LIBRARIES_OLD ${CMAKE_REQUIRED_LIBRARIES})
+	IF(BUILD_SHARED_LIBS)
+		SET(CMAKE_REQUIRED_LIBRARIES ${LIBSSH2_LIBRARIES})
+		SET(LIBSSH2_TMP_LIBRARY_DIRS ${LIBSSH2_LIBRARY_DIRS})
+	ELSE()
+		SET(CMAKE_REQUIRED_LIBRARIES ${LIBSSH2_STATIC_LIBRARIES})
+		SET(LIBSSH2_TMP_LIBRARY_DIRS ${LIBSSH2_STATIC_LIBRARY_DIRS})
+	ENDIF()
+	CHECK_LIBRARY_EXISTS(ssh2 libssh2_userauth_publickey_frommemory "${LIBSSH2_TMP_LIBRARY_DIRS}" HAVE_LIBSSH2_MEMORY_CREDENTIALS)
+	SET(CMAKE_REQUIRED_LIBRARIES ${CMAKE_REQUIRED_LIBRARIES_OLD})
+	UNSET(LIBSSH2_TMP_LIBRARY_DIRS)
 	IF (HAVE_LIBSSH2_MEMORY_CREDENTIALS)
 		SET(GIT_SSH_MEMORY_CREDENTIALS 1)
 	ENDIF()
