8000 🌐 Update Spanish translation including new illustrations in `docs/es/docs/async.md` by andresbermeoq · Pull Request #9483 · fastapi/fastapi · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@andresbermeoq
Copy link
Contributor

The changes that were explicated in the #9474.

@github-actions
Copy link
Contributor
github-actions bot commented May 3, 2023

📝 Docs preview for commit e90d46c at: https://64529833b96ac5452f7b3ea8--fastapi.netlify.app

Copy link
@LaurEars LaurEars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • One question about changes to .gitignore - pls change ❌
  • Ran this branch locally and images load properly and in correct locations, according to the original english documentation ✅

@tiangolo tiangolo changed the title Add images in the spanish translation. 🌐 Update Spanish translation including new illustrations in docs/es/docs/async.md May 8, 2023
@tiangolo tiangolo added lang-all Translations lang-es Spanish translations awaiting-review labels May 8, 2023
@github-actions
Copy link
Contributor
github-actions bot commented May 8, 2023

📝 Docs preview for commit 7737b4e at: https://6458fe8a95db9d38097eea9d--fastapi.netlify.app

Copy link
@LaurEars LaurEars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias 🙏

Copy link
@piaria piaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias!

@github-actions
Copy link
Contributor

📝 Docs preview for commit afe0899 at: https://64644378e8d13f5422b57568--fastapi.netlify.app

@marcorichetta
Copy link

@github-actions
Copy link
Contributor

📝 Docs preview for commit ae39d84 at: https://64650c1f93b290127d4edfb9--fastapi.netlify.app

@tiangolo
Copy link
Member
tiangolo commented Jun 3, 2023

Thank you @andresbermeoq! 🚀

Thanks for the reviews @LaurEars, @realFranco, @piaria

Especial thanks to @LaurEars for checking it locally and commenting that, that helps a lot! 🙇

@tiangolo tiangolo merged commit 7cdee0e into fastapi:master Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-es Spanish translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

0