8000 ✅ Fix new/recent tests with new fixed `ValidationError` JSON Schema by tiangolo · Pull Request #4806 · fastapi/fastapi · GitHub
[go: up one dir, main page]
Skip to content

✅ Fix new/recent tests with new fixed ValidationError JSON Schema #4806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiangolo merged 1 commit into from
Apr 17, 2022
Merged

✅ Fix new/recent tests with new fixed ValidationError JSON Schema #4806

tiangolo merged 1 commit into from
Apr 17, 2022

Conversation

@tiangolo
Copy link
Member
@tiangolo tiangolo commented Apr 17, 2022

✅ Fix new/recent tests with new fixed ValidationError JSON Schema

The JSON Schema for ValidationError was updated/fixed by #3810

That PR also updated the tests that were affected at the moment. But all the new tests added after that were still affected. This PR fixes those recent tests.

@tiangolo tiangolo enabled auto-merge (squash) April 17, 2022 20:52
@codecov
Copy link
codecov bot commented Apr 17, 2022 •
edited
Loading

Codecov Report

Merging #4806 (d8976ae) into master (1d8d81a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #4806   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          529       529           
  Lines        13522     13522           
=========================================
  Hits         13522     13522
Impacted Files Coverage Δ
fastapi/openapi/utils.py 100.00% <ø> (ø)
tests/test_additional_properties.py 100.00% <ø> (ø)
...t_additional_responses_custom_model_in_callback.py 100.00% <ø> (ø)
...st_additional_responses_default_validationerror.py 100.00% <ø> (ø)
tests/test_application.py 100.00% <ø> (ø)
tests/test_dependency_duplicates.py 100.00% <ø> (ø)
tests/test_extra_routes.py 100.00% <ø> (ø)
tests/test_filter_pydantic_sub_model.py 100.00% <ø> (ø)
tests/test_generate_unique_id_function.py 100.00% <ø> (ø)
tests/test_get_request_body.py 100.00% <ø> (ø)
... and 113 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 197c1d6...d8976ae. Read the comment docs.

@github-actions
Copy link
Contributor
github-actions bot commented Apr 17, 2022

🚀 Deployed on https://625c7ea713f19e29f93a4216--fastapi.netlify.app

@tiangolo tiangolo merged commit ddd9da3 into master Apr 17, 2022
@tiangolo tiangolo deleted the validation-error-schema-updates branch April 17, 2022 20:55
@domesticmouse domesticmouse mentioned this pull request May 3, 2022
Closed
@flxdot flxdot mentioned this pull request May 16, 2022
Closed
9 tasks
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
@tiangolo @JeanArhancet
✅ Fix new/recent tests with new fixed ValidationError JSON Schema (f…
7daf8bd 
…astapi#4806)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tiangolo
0