8000 🌐 Add Korean translation for `docs/tutorial/request-files.md` by NinaHwang · Pull Request #3743 · fastapi/fastapi · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@NinaHwang
Copy link
Contributor
@NinaHwang NinaHwang commented Aug 21, 2021

This PR translates tutorial/request-files.md in Korean.

related: #2017

Copy link
Contributor
@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be best if you used less "띄어쓰기".

e.g.

  • something 입니다. -> something입니다.
  • something : 설명 -> something: 설명

Let me know what you think.

NinaHwang and others added 3 commits September 6, 2021 11:42
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
Co-authored-by: Spike <rurouni24@gmail.com>
@NinaHwang
Copy link
Contributor Author

@hard-coders Thank you for the feedback!

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Oct 5, 2021
@github-actions github-actions bot mentioned this pull request Oct 5, 2021
Copy link
Contributor
@0417taehyun 0417taehyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit appreciate of your works and great honor to check it.

Feel free to check my reviews 🚀

Also, please update (fetch) the file to the latest version.


선언한대로, `bytes` 의 `list` 또는 `UploadFile` 들을 전송받을 것입니다.

!!! note "참고"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this note section is deprecated in the docs. Please update (fetch) the file to the latest version.

NinaHwang and others added 14 commits November 28, 2021 13:10
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@codecov
Copy link
codecov bot commented Nov 28, 2021

Codecov Report

Merging #3743 (1fbe028) into master (fb9c4b3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3743   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          409       409           
  Lines        10264     10264           
=========================================
  Hits         10264     10264           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9c4b3...1fbe028. Read the comment docs.

Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
NinaHwang and others added 6 commits November 28, 2021 13:13
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@github-actions
Copy link
Contributor

📝 Docs preview for commit 78dbcf2 at: https://61a303bef233071a028c3fa1--fastapi.netlify.app

Copy link
Contributor
@0417taehyun 0417taehyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tiangolo
Copy link
Member
tiangolo commented Dec 8, 2021

Amazing, thanks @NinaHwang! 🙇 🍪

And thanks for the reviews @hard-coders and @0417taehyun! 🚀

@tiangolo tiangolo enabled auto-merge (squash) December 8, 2021 15:48
@tiangolo tiangolo merged commit fa5639c into fastapi:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0