8000 Translate doc first steps to Chinese by waynerv · Pull Request #1323 · fastapi/fastapi · GitHub
[go: up one dir, main page]
Skip to content

Translate doc first steps to Chinese #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiangolo merged 4 commits into from
Jun 12, 2020
Merged

Translate doc first steps to Chinese #1323

tiangolo merged 4 commits into from
Jun 12, 2020

Conversation

@waynerv
Copy link
Contributor
@waynerv waynerv commented Apr 24, 2020

@Dustyposa @RunningIkkyu Please take a look.

@codecov
Copy link
codecov bot commented Apr 24, 2020 •
edited
Loading

Codecov Report

Merging #1323 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1323   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          227       227           
  Lines         6805      6810    +5     
=========================================
+ Hits          6805      6810    +5
Impacted Files Coverage Δ
fastapi/utils.py 100.00% <0.00%> (ø)
fastapi/openapi/utils.py 100.00% <0.00%> (ø)
fastapi/dependencies/utils.py 100.00% <0.00%> (ø)
...test_tutorial/test_path_params/test_tutorial005.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 601d8eb...51c4c6b. Read the comment docs.

@tiangolo tiangolo changed the title Translate doc first steps Translate doc first steps to Chinese May 17, 2020
RunningIkkyu
RunningIkkyu approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor
@RunningIkkyu RunningIkkyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can change all quote marks into 「」.

Laineyzhang55
Laineyzhang55 approved these changes Jun 4, 2020
View reviewed changes
Copy link
@Laineyzhang55 Laineyzhang55 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiangolo tiangolo added lang-all Translations lang-zh Chinese translations labels Jun 7, 2020
@tiangolo tiangolo merged commit 81a529c into fastapi:master Jun 12, 2020
@tiangolo
Copy link
Member
tiangolo commented Jun 12, 2020

Awesome, thanks for your contribution @waynerv ! 🚀 🎉

And thanks for the review/approvals @RunningIkkyu , @Laineyzhang55 , @yanever 🙇 ☕

@waynerv waynerv deleted the translate-doc-first-steps branch June 13, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@yanever yanever yanever approved these changes

@RunningIkkyu RunningIkkyu RunningIkkyu approved these changes

@Laineyzhang55 Laineyzhang55 Laineyzhang55 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lang-all Translations lang-zh Chinese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@waynerv @tiangolo @yanever @RunningIkkyu @Laineyzhang55
0