8000 drop model class from additional responses when generating openapi by nsidnev · Pull Request #1322 · fastapi/fastapi · GitHub
[go: up one dir, main page]
Skip to content

drop model class from additional responses when generating openapi #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiangolo merged 2 commits into from
Jun 12, 2020
Merged

drop model class from additional responses when generating openapi #1322

tiangolo merged 2 commits into from
Jun 12, 2020

Conversation

@nsidnev
Copy link
Contributor
@nsidnev nsidnev commented Apr 24, 2020

There is an error when OpenAPI callbacks use additional responses.
The "model" key is not dropped when generating openapi.json, and an error occurs when encoding the class into json.

@codecov
Copy link
codecov bot commented Apr 24, 2020 •
edited
Loading

Codecov Report

Merging #1322 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1322   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          226       231    +5     
  Lines         6785      6882   +97     
=========================================
+ Hits          6785      6882   +97
Impacted Files Coverage Δ
fastapi/openapi/utils.py 100.00% <100.00%> (ø)
...t_additional_responses_custom_model_in_callback.py 100.00% <100.00%> (ø)
fastapi/utils.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
fastapi/dependencies/utils.py 100.00% <0.00%> (ø)
...test_tutorial/test_path_params/test_tutorial005.py 100.00% <0.00%> (ø)
...t_tutorial/test_behind_a_proxy/test_tutorial002.py 100.00% <0.00%> (ø)
...t_tutorial/test_behind_a_proxy/test_tutorial001.py 100.00% <0.00%> (ø)
...orial/test_conditional_openapi/test_tutorial001.py 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e77737...424a7c8. Read the comment docs.

@nsidnev
Copy link
Contributor Author
nsidnev commented Jun 8, 2020

@tiangolo hi!
Can you review this PR, please?

@tiangolo tiangolo merged commit d66d837 into fastapi:master Jun 12, 2020
@tiangolo
Copy link
Member
tiangolo commented Jun 12, 2020

Awesome, great job @nsidnev ! 🚀

Thanks for finding and fixing the bug! 🤓 🐛 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nsidnev @tiangolo
0