Docs: Update cors.md - CORS max_age 600 #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update max_age documentation from 60 to the actual default value of 600. https://github.com/encode/starlette/blob/master/starlette/middleware/cors.py#L23 Related PR Kludex/starlette#909
Codecov Report
@@ Coverage Diff @@
## master #1301 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 226 226
Lines 6785 6785
=========================================
Hits 6785 6785 Continue to review full report at Codecov.
|
Member
|
Awesome! Thanks for your contribution! 🚀 🍰 And thanks for taking the time to update it on Starlette and here 🤓 ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update max_age documentation from 60 to the actual default value of 600.
https://github.com/encode/starlette/blob/master/starlette/middleware/cors.py#L23
Related PR Kludex/starlette#909