Spanish translation for section async #1290
Merged
8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1290 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 227 226 -1
Lines 6805 6785 -20
=========================================
Continue to review full report at Codecov.
|
Closed
mariacamilagl
requested changes
Apr 26, 2020
Collaborator
There was a problem hiding this comment.
Thank you so much for your effort @alvaropernas 🚀 👍
This was a long, complex one!
I know the changes may look a bit overwhelming, but they are minor details. Here's the summary of the suggestions:
- Removing double spaces and spaces after commas
- Maintaining consistency between "tu" and "usted"
- Keeping the central FastAPI terms like "path operation function" in English for consistency
- Other typos}
Thanks again! 🎉 🍰
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Co-Authored-By: Camila Gutierrez <mariacamilagl@users.noreply.github.com>
Contributor
Author
|
Thanks Maria, I had doubts about what should be translated. |
Collaborator
Hey, no worries. We are also always debating what should or shouldn't be translated. It isn't an exact science at all. Our main concern is to keep in English very technical terms that don´t have comfortable translations to Spanish, or that are core FastAPI terms. Thank you for your work! 🍰 🚀 |
Member
|
Thanks for your contribution @alvaropernas ! 🍰 🚀 And thanks @mariacamilagl for your review and help 🤓 ☕ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here is my first approach.
Appreciate any comments, thks!!