8000 🌐 Add Traditional Chinese translation for `docs/zh-hant/benchmarks.md` by KNChiu · Pull Request #11484 · fastapi/fastapi · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@KNChiu
Copy link
Contributor
@KNChiu KNChiu commented Apr 24, 2024

Add Traditional Chinese translation for docs\zh-hant\benchmarks.md

@tiangolo
Copy link
Member

📝 Docs preview for commit 40ba73b at: https://5ef953b6.fastapitiangolo.pages.dev

@alejsdev alejsdev changed the title 🌐 Add Traditional Chinese translation for docs\zh-hant\benchmarks.md 🌐 Add Traditional Chinese translation for docs/zh-hant/benchmarks.md Apr 24, 2024
@alejsdev alejsdev added lang-all Translations lang-es Spanish translations awaiting-review lang-zh-hant Traditional Chinese translations and removed lang-es Spanish translations labels Apr 24, 2024
Copy link
@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

檔案位置好像放錯囉,應該要是 docs/zh-hant/docs/benchmarks.md
發 PR 記得 local build 或看看 preview 是否如預期

Accept suggestions.

Co-authored-by: Wei-Hsiang (Matt) Wang <mattwang44@gmail.com>
@tiangolo
Copy link
Member

📝 Docs preview for commit 7a89998 at: https://bdf4be30.fastapitiangolo.pages.dev

@tiangolo
Copy link
Member

📝 Docs preview for commit 005ecc3 at: https://60367e93.fastapitiangolo.pages.dev

Copy link
@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 只剩檔案位置問題

@tiangolo
Copy link
Member

📝 Docs preview for commit 50b29ac at: https://d3fde60c.fastapitiangolo.pages.dev

Copy link
@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preview is here
LGTM

@tiangolo
Copy link
Member

📝 Docs preview for commit 3d096d7 at: https://1f1d7ef2.fastapitiangolo.pages.dev

@tiangolo
Copy link
Member

📝 Docs preview for commit 7dafcae at: https://7d91e118.fastapitiangolo.pages.dev

@hsuanchi
Copy link
Contributor

preview is here
LGTM 🚀

@alejsdev alejsdev merged commit 8045f34 into fastapi:master Apr 27, 2024
@alejsdev
Copy link
Member

Thanks for the contribution! @KNChiu 🚀 ✨

And thanks for the reviews @hsuanchi @mattwang44 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-1 lang-all Translations lang-zh-hant Traditional Chinese translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0