8000 ✏️ Fix typo in `docs/en/docs/alternatives.md` by s111d · Pull Request #10931 · fastapi/fastapi · GitHub
[go: up one dir, main page]
Skip to content

✏️ Fix typo in docs/en/docs/alternatives.md #10931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alejsdev merged 2 commits into from
Jan 11, 2024
Merged

✏️ Fix typo in docs/en/docs/alternatives.md #10931

alejsdev merged 2 commits into from
Jan 11, 2024

Conversation

@s111d
Copy link
Contributor
@s111d s111d commented Jan 10, 2024

Pluralize

@s111d
Fix typo
6cae29a 
Pluralize
@tiangolo
Copy link
Member
tiangolo commented Jan 10, 2024

📝 Docs preview for commit 6cae29a at: https://f13a4dfa.fastapitiangolo.pages.dev

@s111d
Copy link
Contributor Author
s111d commented Jan 10, 2024 •
edited
Loading

Also: I'm not sure if its worth attention, but should'n the bullet here be just like "Info" bullets below and not "Note": https://fastapi.tiangolo.com/alternatives/#django-rest-framework
I'm asking because from what I see, creators of something usually go under "Info" section. See here, for example: https://fastapi.tiangolo.com/alternatives/#webargs

@hasansezertasan
Copy link
Contributor
hasansezertasan commented Jan 10, 2024 •
edited
Loading

Also: I'm not sure if its worth attention, but should'n the bullet here be just like "Info" bullets below and not "Note": https://fastapi.tiangolo.com/alternatives/#django-rest-framework I'm asking because from what I see, creators of something usually go under "Info" section. See here, for example: https://fastapi.tiangolo.com/alternatives/#webargs

I feel you, I think you should make those changes and commit but the documentation looks a bit (quite a bit) personal. So IDK if we have a say in this matter.

Edit: Because it's a bit personal, the author might feel like "it's a note, instead of info..."

@s111d
Copy link
Contributor Author
s111d commented Jan 10, 2024

Another thing, same file: "Angular two" – maybe just plainly "Angular 2"? Number of version is usually not spelled.

@alejsdev alejsdev changed the title Fix typo ✏️ Fix typo in docs/en/docs/alternatives.md Jan 11, 2024
@alejsdev alejsdev self-requested a review January 11, 2024 14:07
@alejsdev alejsdev added awaiting-review docs Documentation about how to use FastAPI and removed awaiting-review labels Jan 11, 2024
@tiangolo
Copy link
Member
tiangolo commented Jan 11, 2024

📝 Docs preview for commit 8f9d8fa at: https://7130e85e.fastapitiangolo.pages.dev

@alejsdev alejsdev merged commit c46eba8 into fastapi:master Jan 11, 2024
@alejsdev
Copy link
Member
alejsdev commented Jan 11, 2024

Good catch! Thanks @s111d 🐱

Another thing, same file: "Angular two" – maybe just plainly "Angular 2"? Number of version is usually not spelled.

I agreed with this one and made that change as well.

Thanks for your help too @mirovisionepitech and @hasansezertasan ☕

nilslindemann pushed a commit to nilslindemann/fastapi that referenced this pull request Jan 13, 2024
8264
Sync with fastapi#10906 and fastapi#10931
defaa2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alejsdev alejsdev alejsdev approved these changes

+1 more reviewer

@mirovisionepitech mirovisionepitech mirovisionepitech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation about how to use FastAPI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@s111d @tiangolo @hasansezertasan @alejsdev @mirovisionepitech
0