8000 CI Do not auto close tracking issue if tests pass (#23155) · thomasjpfan/scikit-learn@19efe3a · GitHub
[go: up one dir, main page]
Skip to content

Commit 19efe3a

Browse files
thomasjpfanthomasjpfan
authored
CI Do not auto close tracking issue if tests pass (scikit-learn#23155)
1 parent 2b0d2aa commit 19efe3a

File tree

3 files changed

+22
-12
lines changed

3 files changed

+22
-12
lines changed

‎build_tools/azure/posix-docker.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,8 @@ jobs:
134134
$CI_NAME \
135135
$ISSUE_REPO \
136136
$LINK_TO_RUN \
137-
--junit-file $JUNIT_FILE
137+
--junit-file $JUNIT_FILE \
138+
--auto-close false
138139
displayName: 'Update issue tracker'
139140
env:
140141
JUNIT_FILE: $(TEST_DIR)/$(JUNITXML)

‎build_tools/azure/posix.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,8 @@ jobs:
103103
$CI_NAME \
104104
$ISSUE_REPO \
105105
$LINK_TO_RUN \
106-
--junit-file $JUNIT_FILE
106+
--junit-file $JUNIT_FILE \
107+
--auto-close false
107108
displayName: 'Update issue tracker'
108109
env:
109110
JUNIT_FILE: $(TEST_DIR)/$(JUNITXML)

‎maint_tools/update_tracking_issue.py

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,14 @@
3535
"exists. If tests-passed is false, then the an issue is updated or created."
3636
),
3737
)
38+
parser.add_argument(
39+
"--auto-close",
40+
help=(
41+
"If --auto-close is false, then issues will not auto close even if the tests"
42+
" pass."
43+
),
44+
default="true",
45+
)
3846

3947
args = parser.parse_args()
4048

@@ -73,24 +81,24 @@ def create_or_update_issue(body=""):
7381
print(f"Created issue in {args.issue_repo}#{issue.number}")
7482
sys.exit()
7583
else:
76-
# Update existing issue
77-
issue.edit(title=title, body=body_text)
78-
print(f"Updated issue in {args.issue_repo}#{issue.number}")
84+
# Add comment to existing issue
85+
issue.create_comment(body=body_text)
86+
print(f"Commented on issue: {args.issue_repo}#{issue.number}")
7987
sys.exit()
8088

8189

8290
def close_issue_if_opened():
8391
print("Test has no failures!")
8492
issue = get_issue()
8593
if issue is not None:
86-
print(f"Closing issue #{issue.number}")
87-
new_body = (
88-
"## Closed issue because CI is no longer failing! ✅\n\n"
89-
f"[Successful run]({args.link_to_ci_run})\n\n"
90-
"## Previous failure report\n\n"
91-
f"{issue.body}"
94+
comment = (
95+
f"## CI is no longer failing! ✅\n\n[Successful run]({args.link_to_ci_run})"
9296
)
93-
issue.edit(state="closed", body=new_body)
97+
print(f"Commented on issue #{issue.number}")
98+
issue.create_comment(body=comment)
99+
if args.auto_close.lower() == "true":
100+
print(f"Closing issue #{issue.number}")
101+
issue.edit(state="closed")
94102
sys.exit()
95103

96104

0 commit comments

Comments
 (0)
0