Fix wrong roles comparison

thlbaut · web-flow · commit e041decc2704 · 2020-03-03T16:33:50.000+01:00
Issue : symfony#35941
diff --git a/src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php b/src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php
@@ -323,7 +323,7 @@ private function hasUserChanged(UserInterface $user): bool
             $userRoles[] = 'ROLE_PREVIOUS_ADMIN';
         }
 
-        if (\count($userRoles) !== \count($this->getRoleNames()) || \count($userRoles) !== \count(array_intersect($userRoles, $this->getRoleNames()))) {
+        if (\count($userRoles) !== \count($this->user->getRoles()) || \count($userRoles) !== \count(array_intersect($userRoles, $this->user->getRoles()))) {
             return true;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -323,7 +323,7 @@ private function hasUserChanged(UserInterface $user): bool`
`323`	`323`	`$userRoles[] = 'ROLE_PREVIOUS_ADMIN';`
`324`	`324`	`}`
`325`	`325`
`326`		`- if (\count($userRoles) !== \coun 5251 t($this->getRoleNames()) \|\| \count($userRoles) !== \count(array_intersect($userRoles, $this->getRoleNames()))) {`
	`326`	`+ if (\count($userRoles) !== \count($this->user->getRoles()) \|\| \count($userRoles) !== \count(array_intersect($userRoles, $this->user->getRoles()))) {`
`327`	`327`	`return true;`
`328`	`328`	`}`
`329`	`329`