Merge pull request #198 from Ferrisbane/Ferrisbane-patch-protocol-4-0-fields

judgej · web-flow · commit 2a2dd855aecf · 2024-03-25T21:24:51.000Z
Fix protocol 4.00 VPSSignature check
diff --git a/src/Message/ServerCompleteAuthorizeRequest.php b/src/Message/ServerCompleteAuthorizeRequest.php
@@ -53,7 +53,12 @@ public function getSignature()
             $this->httpRequest->request->get('DeclineCode', '').
             $this->httpRequest->request->get('ExpiryDate', '').
             $this->httpRequest->request->get('FraudResponse', '').
-            $this->httpRequest->request->get('BankAuthCode', '');
+            $this->httpRequest->request->get('BankAuthCode', '').
+            // New for protocol v4.00
+            // Described in the docs here: https://developer.elavon.com/products/opayo-server/v1/notification-of-transaction-result
+            $this->httpRequest->request->get('ACSTransID', '').
+            $this->httpRequest->request->get('DSTransID', '').
+            $this->httpRequest->request->get('SchemeTraceID', '');
 
         return md5($signature_string);
     }
diff --git a/tests/ServerGatewayTest.php b/tests/ServerGatewayTest.php
@@ -120,9 +120,14 @@ public function testCompleteAuthorizeSuccess()
                 'DeclineCode' => '00',
                 'ExpiryDate' => '0722',
                 'BankAuthCode' => '999777',
+                // New fields for protocol v4.0
+                'ACSTransID' => 'abcuuid',
+                'DSTransID' => '123uuid',
+                'SchemeTraceID' => 'V123',
                 'VPSSignature' => md5(
                     '{F955C22E-F67B-4DA3-8EA3-6DAC68FA59D2}'
                     . '438791' . 'OK' . 'bexamplecJEUPDN1N7Edefghijklm' . '00' . '0722' . '999777'
+                    . 'abcuuid' . '123uuid' . 'V123'
                 ),
             )
         );
