8000 Update tests for Oracle identifiers · thecodingmachine/tdbm@44c54f2 · GitHub
[go: up one dir, main page]

Skip to content

Commit 44c54f2

Browse files
committed
Update tests for Oracle identifiers
1 parent b544ea8 commit 44c54f2

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

tests/TDBMAbstractServiceTest.php

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -797,22 +797,28 @@ private static function initSchema(Connection $connection): void
797797
self::insert($connection, 'all', ['analyze' => 1, 'and' => 1]);
798798
}
799799

800-
public static function insert(Connection $connection, string $tableName, array $data): void
800+
private static function quoteKeys(Connection $connection, array $data): array
801801
{
802802
$quotedData = [];
803803
foreach ($data as $id => $value) {
804804
$quotedData[$connection->quoteIdentifier($id)] = $value;
805805
}
806-
$connection->insert($connection->quoteIdentifier($tableName), $quotedData);
806+
return $quotedData;
807807
}
808808

809-
protected static function delete(Connection $connection, string $tableName, array $data): void
809+
public static function insert(Connection $connection, string $tableName, array $data): void
810810
{
811-
$quotedData = [];
812-
foreach ($data as $id => $value) {
813-
$quotedData[$connection->quoteIdentifier($id)] = $value;
814-
}
815-
$connection->delete($connection->quoteIdentifier($tableName), $quotedData);
811+
$connection->insert($connection->quoteIdentifier($tableName), self::quoteKeys($connection, $data));
812+
}
813+
814+
public static function update(Connection $connection, string $tableName, array $data, array $criteria): void
815+
{
816+
$connection->update($connection->quoteIdentifier($tableName), self::quoteKeys($connection, $data), self::quoteKeys($connection, $criteria));
817+
}
818+
819+
protected static function delete(Connection $connection, string $tableName, array $criteria): void
820+
{
821+
$connection->delete($connection->quoteIdentifier($tableName), self::quoteKeys($connection, $criteria));
816822
}
817823

818824
protected static function isMariaDb(Connection $connection): bool

tests/TDBMDaoGeneratorTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1161,7 +1161,7 @@ public function testDiscardChangesDiscardsRelations(): void
11611161

11621162
$oldCount = $countryBean->getBoatsByAnchorageCountry()->count();
11631163

1164-
$this->tdbmService->getConnection()->insert('boats', [
1164+
self::insert($this->tdbmService->getConnection(), 'boats', [
11651165
'name' => 'RoseBud2',
11661166
'anchorage_country' => 1,
11671167
'current_country' => 1,
@@ -1188,7 +1188,7 @@ public function testDiscardChangesDiscardsRowRef(): void
11881188
$this->assertNotEquals($newExpectedId, $oldId, 'The IDs are the same, the test won\'t have any effect');
11891189

11901190
$userBean->setCountry($countryDao->getById($oldId)); // This triggers the `DbRow::setRef` method which causes the issue
1191-
$this->tdbmService->getConnection()->update('users', ['country_id' => $newExpectedId], ['id' => 4]);
1191+
self::update($this->tdbmService->getConnection(), 'users', ['country_id' => $newExpectedId], ['id' => 4]);
11921192

11931193
$userBean->discardChanges();
11941194

0 commit comments

Comments
 (0)
0